Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-44010

heap_profiler.cpp a few bugs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor - P4
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.5 Desired
    • Component/s: Internal Code
    • Labels:
      None
    • Operating System:
      ALL

      Description

      In file heap_profiler.cpp

      member functions like size(), hash(), operator==, need const.
      Consider replacing private HashTable implementation with standard one.

      L479 bounds on j are infinite if numFrames < skipEndFrames.

      L486 first paren isn't necessarily start of function params.
      for example, "_Z1gIEPFviEv" demangles to "void (*g<>())(int)", a function returning a function pointer. Maybe just don't demangle.

      L502 StringData receives a dangling reference.

       

       

       

       

       

       

        Attachments

          Activity

            People

            Assignee:
            backlog-server-devtools Backlog - Dev Tools
            Reporter:
            billy.donahue Billy Donahue
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated: