Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-44129

Consolidate unowned and owned CollatorInterface's in ExpressionContext

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: Aggregation Framework
    • Labels:
      None

      Description

      As far as I can tell, the distinction exists because there are certain commands which require an ExpressionContext but manage a unique_ptr to the resolved collator on their own. This is confusing especially to new engineers, since its not obvious which one is valid and when.

      As part of the review for SERVER-43844, a couple of ideas involved holding by intrusive_ptr or always cloning the collator even if its "owned" elsewhere.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: