Convert keyStringAssert() and keyStringAsserted() into a macro to avoid evaluating parameters early

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.3.1
    • Affects Version/s: None
    • Component/s: Storage
    • None
    • Fully Compatible
    • Execution Team 2019-11-04
    • 0
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      SERVER-42414 caused a performance regression due to the newly added keyStringAssert() function. The root cause of this regression was that the boolean parameter expr in the function was being evaluated before entering the function, which was previously an explicit MONGO_unlikely condition in the uassert macro.

            Assignee:
            Gregory Wlodarek
            Reporter:
            Gregory Wlodarek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: