Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-44185

Convert keyStringAssert() and keyStringAsserted() into a macro to avoid evaluating parameters early

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.3.1
    • None
    • Storage
    • None
    • Fully Compatible
    • Execution Team 2019-11-04
    • 0

    Description

      SERVER-42414 caused a performance regression due to the newly added keyStringAssert() function. The root cause of this regression was that the boolean parameter expr in the function was being evaluated before entering the function, which was previously an explicit MONGO_unlikely condition in the uassert macro.

      Attachments

        Activity

          People

            gregory.wlodarek@mongodb.com Gregory Wlodarek
            gregory.wlodarek@mongodb.com Gregory Wlodarek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: