Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-45156

SockAddr constructor should take sockaddr, not sockaddr_storage

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.2.5, 4.3.3, 3.6.18, 4.0.18
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible
    • ALL
    • v4.2, v4.0, v3.6
    • Security 2019-12-30
    • 50

      The SockAddr constructor:
      SockAddr::SockAddr(const sockaddr_storage& other, socklen_t size)
      will deep copy sockaddr_storage based on sizeof(sockaddr_storage).

      The sockaddr_storage type should only be used for storing data and not be a constructor parameter. The constructor should instead take a (sockaddr*, socklen_t).

            Assignee:
            mark.benvenuto@mongodb.com Mark Benvenuto
            Reporter:
            mark.benvenuto@mongodb.com Mark Benvenuto
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: