Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-45156

SockAddr constructor should take sockaddr, not sockaddr_storage

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.5, 4.3.3, 3.6.18, 4.0.18
    • Component/s: None
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.2, v4.0, v3.6
    • Sprint:
      Security 2019-12-30
    • Linked BF Score:
      50

      Description

      The SockAddr constructor:
      SockAddr::SockAddr(const sockaddr_storage& other, socklen_t size)
      will deep copy sockaddr_storage based on sizeof(sockaddr_storage).

      The sockaddr_storage type should only be used for storing data and not be a constructor parameter. The constructor should instead take a (sockaddr*, socklen_t).

        Attachments

          Issue Links

          is depended on by

          Question - SERVER-42278 Log SockAddrs produced during LDAP connection establishment with manually derived sizes

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              mark.benvenuto Mark Benvenuto
              Reporter:
              mark.benvenuto Mark Benvenuto
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: