Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-45260

shell helpers in shell_utils_launcher.cpp shouldn't use verify()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4.1, 4.7.0
    • Component/s: Shell
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.4
    • Sprint:
      Dev Tools 2020-02-24, Dev Tools 2020-03-09, Service Arch 2020-04-06, Service arch 2020-04-20, Service arch 2020-05-04
    • Linked BF Score:
      48

      Description

      Some shell helpers like PathExists use verify in their implementations. There's no real good reason for this, and it causes the debug versions of the shell to crash on incorrect inputs.

      A list of locations in shell_utils_launcher.cpp that should probably get fixed up includes:

      • ResetDbpath
      • PathExists
      • CopyDbpath
      • getSignal
      • ProgrammerRunner's ctor

        Attachments

          Activity

            People

            Assignee:
            billy.donahue Billy Donahue
            Reporter:
            jason.carey Jason Carey
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: