Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-45618

eslint taking 30+ minutes in Commit Queue

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.3
    • Component/s: Testing Infrastructure
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Sprint:
      Dev Platform 2020-01-27

      Description

      We are seeing a lot of instances in the commit queue of eslint taking 30+ minutes. After some discussion, it seems like changes might not be using the correct git diff and causing the task to lint the entire code base.

      Here is a sample task that hit 36 minutes.

      From Jonathan Brill:

      I think it should work if we diff the upstream master with the working tree, something like git diff master@{upstream}, substituting the branch name of the project for master (I think there's a "branch_name" expansion).

      This should work whether or not the patch is a commit queue patch.

       

        Attachments

          Activity

            People

            Assignee:
            mathew.robinson Mathew Robinson (Inactive)
            Reporter:
            david.bradford David Bradford
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: