Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-46510

Concurrent drop-pending notifications can race with subsequent transactions

    XMLWordPrintable

Details

    • ALL
    • Hide

      Repro attached, applied on commit 7f9424413d86afeae33e3563c5a33fcb95317e2e on the 4.0 branch.

      Show
      Repro attached, applied on commit 7f9424413d86afeae33e3563c5a33fcb95317e2e on the 4.0 branch.
    • 0

    Description

      Replication two-phase drop (4.0 and eMRC=F) finishes dropping collections when the drop oplog entry gets majority committed. drop commands with w:majority wait until their collections finish dropping to return to the user. Tests expect that after executing a drop with w:majority they can safely move onto the next operation, including transactions which have a 5ms lock timeout. If the majority commit point gets advanced multiple times concurrently, multiple notifications can schedule tasks to complete the same two phase drop. The first scheduled task will succeed and will let the w:majority drop return to the user. At this point the user may start a transaction. The other drop-pending notifications that are still scheduled will eventually be run and will acquire a database lock to complete the collection drop. This can cause the transaction to get a lock timeout. It's a TransientTransactionError that could be easily retried, but our tests do not expect to get a TransientTransactionError everywhere this is possible.

      Sequence of events

      1. Thread A gets a drop command and waits on write concern majority
      2. Thread B gets notified to drop the collection
      3. Thread B drops the collection
      4. Thread C gets notified to drop the collection
      5. Thread A returns to the user
      6. Thread C acquires an X lock on the 'test' database
      7. Thread A starts a transaction and conflicts with thread C's lock.

      Attachments

        1. bf-10827.diff
          4 kB
          Judah Schvimer

        Issue Links

          Activity

            People

              milkie@mongodb.com Eric Milkie
              judah.schvimer@mongodb.com Judah Schvimer
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: