The contract for doReplSetReconfig (as observed by all callers) is that it should always return a bad status on error and never throw (no callers catch exceptions). There is an exception to this when waiting for the config to be replicated to a majority (here) - that should be changed to a status return.