Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-47226

Reevaluate how to handle lint for modules

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Testing Infrastructure
    • None
    • Server Development Platform

    Description

      Currently, when we run lint tasks in patch builds and the commit queue, we will look to git to determine which files have actually changed and only lint the changed files (In mainline builds, we will lint the entire codebase). This saves a significant amount of time in those builds.

      However, it is challenging to determine which files have changed due to modules. Since each module is its own git repository, we need to get the git diff of each of the modules. Additionally, due to how patch build and the commit queue work, we need to ensure the diff is against the base revision of each module. So we need a way to pass the those revisions to whatever code is doing those diffs.

      We currently are specifically checking for the enterprise module, which works for it but doesn't handle the more generalized case of any module being added.

      We should determine a better way of handling this.

      Attachments

        Activity

          People

            backlog-server-devplatform [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
            david.bradford@mongodb.com David Bradford (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: