Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-4739

Race condition in log rotation (was: SIGUSR1 should set a flag rather than doing rotation)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • 2.2.0, 2.2.2
    • 2.2.5, 2.4.4, 2.5.0
    • Logging, Stability
    • None

    Description

      The locking within logRotate only covers the swap of file handles, but renaming an open log file while it is being written to by another thread is not safe. The locking needs to be modified so that no race conditions exist.

      In addition, doing log rotation from a signal handler may be unsafe. It would be better to set a flag in the signal handler, and respond to it from a normal (non-signal) code path. For example, we could rotate the log next time something is logged.

      Currently there is a deadlock if the current thread is in the middle of logging.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-7707 MongoDB 2.2.1/Linux, 32-bit crashing upon log rotation

          • Critical - P2 - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-3339 mongod process hangs after USR1 signal

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-9578 mongos dies on SIGUSR1 instead of rotating logs

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-4905 logRotate should conform to standard log rotation mechanisms

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              Votes:
              24 Vote for this issue
              Watchers:
              29 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: