Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-47798

Audit isMaster response validation for mongod and mongos

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.19, 3.6.19, 4.2.8, 4.4.0-rc6, 4.7.0
    • Component/s: None
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Backport Requested:
      v4.4, v4.2, v4.0, v3.6
    • Sprint:
      Repl 2020-05-18

      Description

      This came out of the conversation in SERVER-47750. We should have tests that validate the fields of isMaster responses to ensure that the server is returning the correct types.

      For mongod, this may already be covered in our unittests and the nature of using setter functions (which would throw compiler errors if we passed an incorrect type as a parameter).

      Mongos' isMaster responses fields are set directly on the response object, and we don't seem to have any test coverage for validating the types returned.

      Ideally, we would use the IDL for isMaster responses, but until then, it might make sense to add an integration test verifying that isMaster responses are returning the types that the drivers expect.

        Attachments

          Activity

            People

            Assignee:
            pavithra.vetriselvan Pavithra Vetriselvan
            Reporter:
            pavithra.vetriselvan Pavithra Vetriselvan
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: