Avoid leaking exceptions in establishCursors cleanup callback

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.4.0-rc7, 4.7.0
    • Affects Version/s: 4.5.1, 4.4.0-rc4
    • Component/s: Querying
    • Fully Compatible
    • ALL
    • v4.4
    • Query 2020-06-01
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      This uassert can trigger when the task executor is shutting down. The exception will bubble up, through this function marked noexcept. I would suggest getting rid of the uassert and instead log a message when args.status is not OK.

      It would also be good to add some documentation about the rules of callbacks and exception throwing. My guess is that callback functions passed to TaskExecutor::scheduleWork() should never throw but I don't see any warnings about it in task_executor.h.

              Assignee:
              Nicholas Zolnierz
              Reporter:
              Ian Boros
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: