Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-48900

Remove "format-string" arguments from logv2 statements in query code

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • None
    • Querying
    • Fully Compatible
    • Query 2020-08-24

    Description

      In related ticket SERVER-48353, we cleaned up the automatically-generated attribute names for logv2 to be more readable. However, many logging statements still provide both a "format-string" and "message-string". In the master branch, only the "message-string" is ever used for structured JSON logs. The "format-string" was necessary during the transition from text logs to JSON logs, but is now vestigial. The "format-strings" reduce readability of the code, since they are largely redundant with the "message-string". We should delete the "format-string" argument from logging statements in the following directories:

      • db/query
      • s/query
      • db/views
      • db/matcher
      • db/exec

      Attachments

        Issue Links

          Activity

            People

              milena.ivanova@mongodb.com Milena Ivanova
              david.storch@mongodb.com David Storch
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: