Minor - P4 We had a report that the server produces the following fail point-related message in logs:
Line 24160: {
"t": {
"$date": "2020-07-01T16:46:48.767+01:00"
},
"s": "I",
"c": "COMMAND",
"id": 4898500,
"ctx": "conn5238",
"msg": "Should activate 'failCommand' failpoint",
"attr": {
"data": {
"failCommands": ["isMaster"],
"appName": "timeoutMonitorCheckTestAsyncTrue",
"blockConnection": true,
"blockTimeMS": 1000
},
"threadName": "conn5238",
"appName": "timeoutMonitorCheckTestAsyncTrue",
"namespace": "admin",
"isInternalClient": 0,
"command": "isMaster"
}
}
This message is not clear as to what the server is communicating. Is the fail point being activated when the message is logged? Will the fail point be activated at some point in the future? Was the server going to activate the fail point but could not?
As a user of the server I would like the message to be more clear as to what the situation it is referring to is.
Example suggested rewording: "Activating fail point"
The message appears to be produced by CommandHelpers::shouldActivateFailCommandFailPoint.