Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-49232

Confusing log message when fail point is activated

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: 4.4.0-rc11
    • Fix Version/s: 4.8.1, 4.4.3
    • Component/s: None
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.4
    • Sprint:
      Service arch 2020-06-29, Service arch 2020-07-13, Service arch 2020-10-19

      Description

      We had a report that the server produces the following fail point-related message in logs:

      Line 24160: {
          "t": {
              "$date": "2020-07-01T16:46:48.767+01:00"
          },
          "s": "I",
          "c": "COMMAND",
          "id": 4898500,
          "ctx": "conn5238",
          "msg": "Should activate 'failCommand' failpoint",
          "attr": {
              "data": {
                  "failCommands": ["isMaster"],
                  "appName": "timeoutMonitorCheckTestAsyncTrue",
                  "blockConnection": true,
                  "blockTimeMS": 1000
              },
              "threadName": "conn5238",
              "appName": "timeoutMonitorCheckTestAsyncTrue",
              "namespace": "admin",
              "isInternalClient": 0,
              "command": "isMaster"
          }
      }

      This message is not clear as to what the server is communicating. Is the fail point being activated when the message is logged? Will the fail point be activated at some point in the future? Was the server going to activate the fail point but could not?

      As a user of the server I would like the message to be more clear as to what the situation it is referring to is.

      Example suggested rewording: "Activating fail point"

      The message appears to be produced by CommandHelpers::shouldActivateFailCommandFailPoint.

        Attachments

          Activity

            People

            Assignee:
            gabriel.russell Gabriel Russell (Inactive)
            Reporter:
            oleg.pudeyev Oleg Pudeyev
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: