Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-49336

Set client metadata if it is missing during failCommand

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 4.9.0, 4.2.15, 4.4.7
    • None
    • None
    • Fully Compatible
    • v4.4, v4.2
    • Service arch 2020-10-19
    • 133

    Description

      We set the ClientIsMasterMetadataState with appName here. Unfortunately, that happens after we evaluate failCommand here, so the first isMaster cannot have appName filters be applied to it.

      The full solution is most likely to separate parse() from run() for isMaster. However, that is potentially disruptive to backport. The less intrusive answer is to separate the functionality that sets the metadata into its own function. We can then invoke that function in failCommand if we don't have client metadata.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. SERVER-56935 "ClientMetadata was previously set" invariant in embedded SDK

          • Major - P3 - Major loss of function.
          • Closed
          is depended on by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-49220 failCommand with appName does not fail connection handshake command

          • Major - P3 - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-48932 ReplicaSetMonitor hitting failpoint set during drivers test

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-49220 failCommand with appName does not fail connection handshake command

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-49815 mongos attach user client metadata to non-user request

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-50804 Make external (application) client info available for commands on shards and config servers

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-53334 Hitting unexpected invariant failure, causing server shutdown

          • Critical - P2 - Crashes, loss of data, severe memory leak.
          • Closed
          related to

          Task - A task that needs to be done. SERVER-50517 Rename ClientMetadataIsMasterState to ClientMetadataHelloState

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-50804 Make external (application) client info available for commands on shards and config servers

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              ben.caimano@mongodb.com Benjamin Caimano (Inactive)
              ben.caimano@mongodb.com Benjamin Caimano (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: