Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-49881

remove noop std::move from CollectionCatalog::setCollectionNamespace() rollback handler

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Gone away
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Storage
    • Labels:
      None

      Description

      This std::move in the RecoveryUnit rollback handler has no effect on the movable type NamespaceString 'fromCollection' because 'fromCollection' is captured as a const variable in the lambda. In addition to removing the confusing std::move, this would also be a good opportunity to add some unit test coverage for the rollback handler.

        Attachments

          Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. SERVER-50145 Have DDL operations and MODE_X writers install a new Collection object

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-49800 add use-after-move rule to clang-tidy evergreen builder

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              backlog-server-execution Backlog - Storage Execution Team
              Reporter:
              benety.goh Benety Goh
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: