Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-49881

remove noop std::move from CollectionCatalog::setCollectionNamespace() rollback handler

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Gone away
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Storage
    • Labels:
      None
    • Storage Execution

      This std::move in the RecoveryUnit rollback handler has no effect on the movable type NamespaceString 'fromCollection' because 'fromCollection' is captured as a const variable in the lambda. In addition to removing the confusing std::move, this would also be a good opportunity to add some unit test coverage for the rollback handler.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            benety.goh@mongodb.com Benety Goh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: