Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-50516

Rename variables in sdam_datatypes.h

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.9.0
    • None
    • Replication
    • None
    • Fully Compatible
    • Service arch 2020-11-02

    Description

      Since we've changed CmdIsMaster to CmdHello in both replication_info and cluster_is_master_cmd (the latter file name is going to change), we should consider renaming classes like IsMasterOutcome to HelloOutcome.

      This will help with maintaining consistency across various server classes that use metadata from the hello command. We will be doing something similar with IsMasterResponse (HelloResponse) and IsMasterMetrics (HelloMetrics).

      We can also change IsMasterRTT to HelloRTT or even handshakeRTT.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            pavithra.vetriselvan@mongodb.com Pavithra Vetriselvan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: