Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-50765

[SBE] Decide if ArraySet should be renamed, if the getElement VM instruction should work with ArraySets, etc.

    XMLWordPrintableJSON

Details

    • Icon: Question Question
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Querying
    • Query 2021-01-11, Query 2021-01-25, Query 2021-02-08

    Description

      The diff for SERVER-49226 added the getElement VM instruction.

      While SERVER-49226 was being worked on, the question came up about whether the "getElement" VM instruction should work with ArraySets. ArraySets don't maintain elements in insertion order or in sorted order, so it wasn't clear if it would make sense for to support "getElement" working with ArraySets.

      Questions also came up about whether the name "ArraySet" is misleading (because ArraySets don't maintain elements in insertion order), whether it would make sense to rename "ArraySet" to "HashSet" (or something similar), and whether isArray() should return true or false for ArraySets (currently it returns true).

      Finally, questions came up about whether it would make sense to change the underlying implementation of "ArraySet" so that it maintains elements in some kind of order (either insertion order or sorted order).

      The goal of this task is to answer these questions, to figure out what changes we want to make to ArraySet (if any), and then to open tasks for this work as appropriate.

       

      Attachments

        Activity

          People

            andrew.paroski@mongodb.com Drew Paroski
            andrew.paroski@mongodb.com Drew Paroski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: