Loading...

XML

Word

Printable

JSON

Type: Bug
Resolution: Unresolved
Priority: Major - P3
Fix Version/s: None
Affects Version/s: None
Component/s: Internal Code
Labels:
- sa-remove-fv-backlog-22

Assigned Teams:

Service Arch
Backwards Compatibility:
Fully Compatible
Operating System:
ALL
Steps To Reproduce:

Hide

BF-18712

Show
BF-18712
Sprint:
Service arch 2020-10-05, Service arch 2020-10-19, Service Arch 2021-03-08, Service Arch 2021-03-22, Service Arch 2021-04-05, Service Arch 2021-04-19, Service Arch 2021-05-17, Service Arch 2021-07-12, Service Arch 2021-08-09
Linked BF Score:
5
Story Points:
4

BF-18712 shows a TSAN true positive where setFastClockSource races with getFastClockSource due to latch_detail::Mutex::_onContendedLock's invocation of getFastClockSource before the setFastClockSource could occur.

There is no synchronization on the unique_ptr fields of ServiceContext, so these problems are unavoidable. Rather than making new obscure rules about when it's ok to call the getters, we can rather easily add synchronization to these fields, as they are private members. They could be stored in a synchronized unique_ptr wrapper.

Acceptance Criteria:

ServiceContext will call terminate if a setter happens after a given property has been accessed. Create a patch build to reproduce this and identify all the use cases where this was happening to create tickets that require a fix.

causes

SERVER-51165 synchronized ServiceContext getters are too slow

Closed

has to be done after

SERVER-58450 Avoid resetting `ServiceContext` members in `db_catalog_test`

Closed

SERVER-58451 Avoid resetting `ServiceContext` members in `db_pipeline_test`

Closed

SERVER-58452 Avoid resetting `ServiceContext` members in `db_repl_coordinator_test`

Closed

SERVER-58453 Avoid resetting `ServiceContext` members in `db_repl_test`

Closed

SERVER-58454 Avoid resetting `ServiceContext` members in `CursorManagerTest`

Closed

SERVER-58455 Avoid resetting `ServiceContext` members in `repltests`

Closed

SERVER-58456 Avoid resetting `ServiceContext` members in `mongo_embedded_test`

Closed

SERVER-58457 Avoid resetting `ServiceContext` members in `db_s_config_server_test`

Closed

SERVER-58458 Avoid resetting `ServiceContext` members in `db_s_shard_server_test`

Closed

SERVER-58459 Avoid resetting `ServiceContext` members in `db_stats_test`

Closed

SERVER-58461 Avoid resetting `ServiceContext` members in `db_unittest_test`

Closed

SERVER-58462 Avoid resetting `ServiceContext` members in `KeyGeneratorUpdateTest`

Closed

is duplicated by

SERVER-84118 Investigate where to reset FastClockSource in service context for mongos

Closed

related to

SERVER-59157 Add support for a shared-mutex type

Closed

SERVER-58336 Use the fixture's instance of ServiceContext in CacheTest tests

Closed

(8 has to be done after, 1 is duplicated by, 2 related to)

Assignee:: [DO NOT USE] Backlog - Service Architecture

Reporter:: Billy Donahue

Participants:: [DO NOT USE] Backlog - Service Architecture, Billy Donahue, Githook User

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: Sep 18 2020 06:35:38 PM UTC

Updated:: Apr 18 2024 07:46:23 PM UTC

Details

Description

Attachments

Issue Links

Activity

People

Dates