Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-51078

waitWhileFailPointEnabled() interruptibility should be reevaluated

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • ALL
    • Service arch 2020-12-28, Service Arch 2021-02-08
    • 12

      CurOpFailpointHelpers::waitWhileFailPointEnabled() here takes a checkForInterrupt argument that is set to false by default. It is set to true in a small handful of cases. It also has the ability take a "shouldCheckForInterrupt" data field (see here) that can be set on a test by test basis.

      I believe that CurOpFailpointHelpers::waitWhileFailPointEnabled() should not have this argument and should instead have a consistent default that can be overridden by the "shouldCheckForInterrupt" field. I could see arguments either way for it defaulting to "true" or "false". Either way, some tests will now need to set "shouldCheckForInterrupt", probably based on whether they include intentional interruptions (like sharding/killop.js).

            Assignee:
            gabriel.russell@mongodb.com Gabriel Russell (Inactive)
            Reporter:
            ben.caimano@mongodb.com Benjamin Caimano (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: