Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-5110

ReplicaSetMonitor::check not thread safe wrt _master

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.5, 2.1.1
    • Component/s: Internal Client, Sharding
    • Labels:
      None
    • Operating System:
      ALL

      Description

      It's possible for a thread to notifyFailure(), resetting the _master variable to -1, between the time when the _master variable is checked here and when it is actually used to access the nodes array. We need to acquire _lock to do this safely.

      There may be other issues here - the _check code modifies _master without locks in other places?

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. SERVER-5833 mongo crash

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-6245 Assertion Error: bsonobjbuilder.h:127

          • Major - P3 - Major loss of function.
          • Closed
          is depended on by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-5302 Mongos Process Dying Signal 11

          • Critical - P2 - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-5166 Removing replica set node can cause mongos to use already freed _nodes entry

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-7841 Segmentation faults and lost replicaset seed on rs.remove()

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-5496 Refactor ReplicaSetMonitor to avoid duplicate work

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-5362 ReplicaSetMonitor::notifySlaveFailure not thread safe

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-5392 Consider allowing only one thread to be responsible in modifying _nodes in ReplicaSetMonitor

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

              People

              Assignee:
              renctan Randolph Tan
              Reporter:
              greg_10gen Greg Studer
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: