Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-51214

Remove dead "waitForHealth" code in ReplSetTest

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Works as Designed
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Replication
    • None
    • Replication

    Description

      'waitForHealth' is an optional parameter to a few ReplSetTest methods, but it always defaults to false, and I don't see any tests using it:

      $ git grep waitForHealth
      src/mongo/shell/replsettest.js:    function _waitForHealth(node, state, timeout) {
      src/mongo/shell/replsettest.js:     * @param {boolean} [waitForHealth] If true, wait for the health indicator of the replica set
      src/mongo/shell/replsettest.js:    this._waitForInitialConnection = function(n, waitForHealth) {
      src/mongo/shell/replsettest.js:        waitForHealth = waitForHealth || false;
      src/mongo/shell/replsettest.js:        if (waitForHealth) {
      src/mongo/shell/replsettest.js:            _waitForHealth(this.nodes[n], Health.UP);
      src/mongo/shell/replsettest.js:     * @param {boolean} [waitForHealth] If true, wait for the health indicator of the replica set
      src/mongo/shell/replsettest.js:        n, options, restart, waitForHealth) {
      src/mongo/shell/replsettest.js:        return this._waitForInitialConnection(n, waitForHealth);
      

      If it's dead code, it would be good to remove it.

      Attachments

        Activity

          People

            backlog-server-repl Backlog - Replication Team
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: