Check return value from SeekableRecordCursor::restore() in various stages

XMLWordPrintableJSON

    • Query 2020-11-02
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      When investigating a coverity ticket for an unchecked return value in SERVER-50838 it was noticed that the return value was unchecked in 

      • CountScan::doRestoreStateRequiresIndex()
      • DistinctScan::doRestoreStateRequiresIndex()
      • sbe::IndexScanStage::doRestoreState()
      • SortedDataInterfaceThrottleCursor::restore()

      Should we add uasserts to check the return values for these calls? We do check the return value in FetchStage.

      uassert(50982, "could not restore cursor for FETCH stage", couldRestore)
      

              Assignee:
              Eric Cox (Inactive)
              Reporter:
              Eric Cox (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: