Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53059

rename to fix spelling Interruptable => Interruptible

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: Internal Code
    • Labels:
      None
    • Fully Compatible
    • Service arch 2020-12-14

      The word is "interruptible".
      Having a misspelling around creates an inconsistency to keep track of.

      Should fix these:

      src/mongo/s/query/blocking_results_merger_test.cpp:188:TEST_F(ResultsMergerTestFixture, ShouldBeInterruptableDuringBlockingNext) {
      src/mongo/util/fail_point_test.cpp:511:void assertFunctionInterruptable(std::function<void(Interruptible* interruptible)> f) {
      src/mongo/util/fail_point_test.cpp:534: assertFunctionInterruptable(
      src/mongo/util/fail_point_test.cpp:544: assertFunctionInterruptable([&failPoint](Interruptible* interruptible) {
      src/mongo/util/future_test_edge_cases.cpp:193: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_edge_cases.cpp:196: ASSERT_EQ(pf.future.waitNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
      src/mongo/util/future_test_edge_cases.cpp:197: ASSERT_EQ(pf.future.getNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
      src/mongo/util/future_test_edge_cases.cpp:204: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_edge_cases.cpp:212: auto res = future.waitNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_edge_cases.cpp:217: res = future.getNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_edge_cases.cpp:226: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_edge_cases.cpp:229: ASSERT_EQ(pf.future.waitNoThrow(&dummyInterruptable), ErrorCodes::Interrupted);
      src/mongo/util/future_test_edge_cases.cpp:237: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_edge_cases.cpp:245: auto res = future.waitNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_edge_cases.cpp:250: res = future.getNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_shared_future.cpp:268: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_shared_future.cpp:271: auto res = shared.waitNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_shared_future.cpp:304: DummyInterruptable dummyInterruptable;
      src/mongo/util/future_test_shared_future.cpp:305: auto res = shared.waitNoThrow(&dummyInterruptable);
      src/mongo/util/future_test_utils.h:54:class DummyInterruptable final : public Interruptible {
      src/mongo/util/interruptible_test.cpp:39:class DummyInterruptable final : public Interruptible {
      src/mongo/util/interruptible_test.cpp:74: auto interruptible = std::make_unique<DummyInterruptable>();
      src/mongo/util/interruptible_test.cpp:113: auto interruptible = std::make_unique<DummyInterruptable>();

            Assignee:
            billy.donahue@mongodb.com Billy Donahue
            Reporter:
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: