Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53100

remove executable permission from source files

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.9.0
    • None
    • Internal Code
    • None
    • Fully Compatible
    • Service arch 2020-11-30

    Description

      These are text files with no need for execute permission.
      Most likely this is from a Windows origin for the files, but execute permission really should not be granted carelessly.

      $ find src/mongo -type f -executable \! \( -name '*.py' -o -name '*.sh' \)
      src/mongo/db/cst/bson_location.h
      src/mongo/db/cst/cst_error_test.cpp
      src/mongo/db/cst/cst_match_test.cpp
      src/mongo/db/cst/cst_match_translation.cpp
      src/mongo/db/cst/cst_match_translation.h
      src/mongo/db/cst/cst_match_translation_test.cpp
      src/mongo/db/cst/cst_parser.h
      src/mongo/db/cst/cst_sort_translation_test.cpp
      src/mongo/db/cst/cst_expression_test.cpp
      src/mongo/db/mongo.ico
      src/mongo/embedded/mongo_embedded/java/gradlew
      src/mongo/installer/compass/Install-Compass.ps1
      src/mongo/installer/compass/install_compass
      src/mongo/shell/mongo.ico
      

      The gradlew and the compass/ files are intentionally executable.
      The others should get a chmod a-x.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: