Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53231

Generate V1 commands' base classes in separate .h/.cpp files

    • Type: Icon: Task Task
    • Resolution: Works as Designed
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Replication
    • Labels:
      None
    • Replication

      Today we generate C++ base classes from IDL for all API Version 1 commands (SERVER-51862). The generated files required the TypedCommand definition so they include commands.h. This tends to produce include-cycles as we convert more V1 commands to IDL: commands.h includes many headers, if one of those headers includes an IDL-generated file that defines a V1 command, a cycle forms.

      Let's give ourselves some flexibility in how we choose to break include-cycles, by generating V1 commands into separate files.

            Assignee:
            backlog-server-repl [DO NOT USE] Backlog - Replication Team
            Reporter:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: