Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53409

refresh some names in FailPoint implementation

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: Internal Code
    • None
    • Fully Compatible
    • Service arch 2020-12-28, Service Arch 2021-02-08

      In order to understand FailPoint's block open and close behavior,

      I found it very helpful to rename several internal entities and reduce the RetCode enum.

      The diff was too big for the ticket it was originally written for and was reverted in the interest of reviewer mercy, but here it is.

      https://mongodbcr.appspot.com/748170001/#ps719300001

      I think a standalone review just focusing on that patch would be very beneficial.

      FailPoint has grown up a lot and some of these names don't cleanly apply.
      For instance, all the ShouldFail stuff is really used for functions besides shouldFail, like executeIf and scopedIf.

            Assignee:
            billy.donahue@mongodb.com Billy Donahue
            Reporter:
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: