Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53580

restore const qualifiers to arguments in test function definitions

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 4.9.0
    • Affects Version/s: None
    • Component/s: Internal Code
    • Labels:
      None
    • Fully Compatible
    • Execution Team 2021-01-25

      In SERVER-51240, we removed the const qualifier from a number of function arguments in some of our unit tests - the clang-tidy rule that motivated this change is more of a check on the function declaration rather than the definitions - it is still ok, even meaningful because it communicates how the function argument is used, to retain some of the const qualifiers in the function definitions.

            Assignee:
            benety.goh@mongodb.com Benety Goh
            Reporter:
            benety.goh@mongodb.com Benety Goh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: