Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53721

Race in failpoint tenantMigrationHangDuringCollectionClone

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Fully Compatible
    • Repl 2021-01-25
    • 17

      This failpoint is error-prone. It is very hard to use it correctly because we check the conditions for the failpoint in TenantCollectionCloner::insertDocumentsCallback. But multiple calls of TenantCollectionCloner::insertDocumentsCallback for different batches could run in parallel because it's scheduled on an executor. So there could be races when using this failpoint together with a small collectionClonerBatchSize because the check for the failpoint's conditions may not align with the batch boundaries.

      I think we can delete this failpoint but use tenantMigrationHangCollectionClonerAfterHandlingBatchResponse instead.

            Assignee:
            lingzhi.deng@mongodb.com Lingzhi Deng
            Reporter:
            lingzhi.deng@mongodb.com Lingzhi Deng
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: