Loading...

XML

Word

Printable

JSON

Type: Task
Resolution: Fixed
Priority: Major - P3
Fix Version/s: 7.1.0-rc0
Affects Version/s: None
Component/s: None
Labels:
- auto-reverted
- techdebt

Assigned Teams:

Storage Execution
Backwards Compatibility:
Fully Compatible
Sprint:
Execution NAMR Team 2023-08-07
Linked BF Score:
200

isCollectionLockedForMode() has a special case where it always returns true if shouldConflictWithSecondaryBatchApplication returns false:
https://github.com/mongodb/mongo/blob/1522b29e65bffd4c438756e5202aef062410864d/src/mongo/db/concurrency/lock_state.cpp#L630-L631

While we might not need to hold locks in this special mode it causes seemingly confusing behavior where the locker reports that locks are held.

We have invariants throughout the codebase that checks if Collections are locked in certain modes. Here are a few that would start firing in certain conditions if the shouldConflictWithSecondaryBatchApplication check is removed from isCollectionLockedForMode

https://github.com/mongodb/mongo/blob/3a4dda6f0dc7f32e91310b9256cd3b499f7715d2/src/mongo/db/pipeline/pipeline_d.cpp#L110-L112

https://github.com/mongodb/mongo/blob/bc41e7992d3c4e84a532e3833623b8e237a281e4/src/mongo/db/storage/wiredtiger/wiredtiger_record_store.cpp#L2458-L2460

https://github.com/mongodb/mongo/blob/bc41e7992d3c4e84a532e3833623b8e237a281e4/src/mongo/db/s/collection_sharding_state.cpp#L120-L121

https://github.com/mongodb/mongo/blob/bc41e7992d3c4e84a532e3833623b8e237a281e4/src/mongo/db/catalog/database_impl.cpp#L529-L530

depends on

SERVER-53846 Clarify locking requirements in createCollectionForApplyOps

Closed

SERVER-79319 Modify collection lock assertions on collection insert path

Closed

SERVER-79320 Modify collection lock assertions for yield restore

Closed

SERVER-79322 Modify collection lock assertion when creating random cursor executor

Closed

SERVER-79323 Modify collection lock check in SBE plan executor

Closed

SERVER-79343 Modify system.views locking assertion in shard role collection acquisition

Closed

SERVER-79344 Modify collection lock assertion for dbHash

Closed

SERVER-79345 Modify collection lock assertions in collection sharding runtime

Closed

SERVER-79346 Modify collection lock assertion in collection sharding state

Closed

SERVER-79347 Modify collection lock assertion in resharding op observer

Closed

SERVER-79348 Modify collection lock assertion when looking up collection for metadata write

Closed

is depended on by

SERVER-79399 Remove ShouldNotConflictWithSecondaryBatchApplicationBlock and related functions

Closed

is duplicated by

SERVER-77474 LockerImpl::isCollectionLockedForMode always returns true in multi-document transactions

Closed

(6 depends on, 1 is depended on by, 1 is duplicated by)

Assignee:: Gregory Noma

Reporter:: Henrik Edin

Participants:: Dianna Hohensee, Githook User, Gregory Noma, Henrik Edin, Jordi Olivares Provencio, xgen-buildbaron-user

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: Jan 14 2021 10:03:19 PM UTC

Updated:: Jun 05 2024 02:12:34 PM UTC

Resolved:: Jul 28 2023 06:39:40 PM UTC

Details

Description

Attachments

Issue Links

Activity

People

Dates