Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-53893

Connpool host-to-pool map is poorly structured

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Won't Do
    • None
    • None
    • Internal Code
    • None
    • Service Arch
    • ALL

    Description

      client/connpool.

      {h,cpp}

      is one of those places where we have poor C++ style and usage.
      There's a std::map that uses a very unusual comparator that uses only part of the key. It's really abusing the std::map API and it's a lot of extra fancy footwork we don't need to do.

      The implementation could be much more elegantly expressed in other ways as well, like using modern C++ like CTAD, auto, ranged-for, structured bindings, etc. It would be much easier to follow at that point.

      Attachments

        Activity

          People

            backlog-server-servicearch Backlog - Service Architecture
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: