Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-54031

errorcodes.py doesn't check embedded C++ code in Python scripts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9.0, 4.4.5, 4.0.24, 4.2.14
    • Component/s: Build
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.4, v4.2, v4.0
    • Sprint:
      Service Arch 2021-03-08

      Description

      We seem to have ended up with a duplicate assert code 40088 between these two places:
      https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/util/generate_icu_init_cpp.py#L110
      https://github.com/mongodb/mongo/blob/d5d4b4945fabfb772b758b95fbfa698c4448484e/src/mongo/db/repl/replication_coordinator_impl.cpp#L767

      I believe this is because buildscripts/errorcodes.py isn't looking in .py files, but it probably can be easily adapted to do so.

      This issue is important because we actually have a problem report from the field with this exact error code.

        Attachments

          Activity

            People

            Assignee:
            billy.donahue Billy Donahue
            Reporter:
            milkie Eric Milkie
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: