Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-54198

--ninja builds should automatically set CCFLAGS=-fdiagnostics-color

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Build
    • None
    • Server Development Platform
    • ALL

    Description

      Ninja captures and buffers stdout and stderr from builds (except when pool=console) which tricks the istty check in compilers. The recommendation from https://github.com/ninja-build/ninja/wiki/FAQ is to add -fdiagnostics-color to the compile flags. Ninja adds its own istty checks and will filter out the color codes if the output isn't a terminal, so it isn't harmful to add the flag always, even when ninja output is redirected.

      Attachments

        Activity

          People

            backlog-server-devplatform [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: