Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-54198

--ninja builds should automatically set CCFLAGS=-fdiagnostics-color

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build
    • Labels:
      None
    • Operating System:
      ALL

      Description

      Ninja captures and buffers stdout and stderr from builds (except when pool=console) which tricks the istty check in compilers. The recommendation from https://github.com/ninja-build/ninja/wiki/FAQ is to add -fdiagnostics-color to the compile flags. Ninja adds its own istty checks and will filter out the color codes if the output isn't a terminal, so it isn't harmful to add the flag always, even when ninja output is redirected.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              backlog-server-devplatform Backlog - Server Development Platform Team (SDP)
              Reporter:
              redbeard0531 Mathias Stearn
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: