--ninja builds should automatically set CCFLAGS=-fdiagnostics-color

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Duplicate
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Build
    • None
    • Server Development Platform
    • ALL
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Ninja captures and buffers stdout and stderr from builds (except when pool=console) which tricks the istty check in compilers. The recommendation from https://github.com/ninja-build/ninja/wiki/FAQ is to add -fdiagnostics-color to the compile flags. Ninja adds its own istty checks and will filter out the color codes if the output isn't a terminal, so it isn't harmful to add the flag always, even when ninja output is redirected.

            Assignee:
            [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
            Reporter:
            Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: