Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-54517

Remove redundant 'shouldFail()' around pauseWhileSet() for hangAfterInitializingIndexBuild failpoint

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Fully Compatible
    • ALL
    • Repl 2021-02-22
    • 17

      This is unintuitive when writing tests that use the 'hangAfterInitializingIndexBuild' fialpoint because shouldFail() and pauseWhileSet() both increment the 'timesEntered' counter by 1. This can lead to unintended races in our tests that rely on the failpoint 'waitForTimesEntered' command. We should remove the shouldFail since pauseWhileSet already does that check internally.

            Assignee:
            jason.chan@mongodb.com Jason Chan
            Reporter:
            jason.chan@mongodb.com Jason Chan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: