Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-54695

The --disable-warnings-as-errors flag should not affect configure checks

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 5.0.0-rc0
    • Affects Version/s: None
    • Component/s: Build
    • None
    • Fully Compatible
    • ALL
    • Dev Platform 2021-03-22, Dev Platform 2021-04-05

      The configure check subsystem relies on generating diagnostics to detect unsupported flags. One some platforms, this requires that -Werror be in play in order for those diagnostics to be fatal. However, the --disable-warnings-as-errors flag inhibits application of -Werror. This can result in configure checks returning surprising results. In particular, if a user has passed an invalid flag in by setting CCFLAGS or similar on the command line but has also applied --disable-warnings-as-errors, the build may proceed despite the erroneous flag. We should ensure that the effect of --disable-warnings-as-errors applies only to our source code, and not to our configure checks.

            Assignee:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Reporter:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: