Loading...

XML

Word

Printable

JSON

Type: Improvement
Resolution: Fixed
Priority: Major - P3
Fix Version/s: 4.9.0
Affects Version/s: None
Component/s: Internal Code
Labels:
None

Backwards Compatibility:
Fully Compatible
Sprint:
Service Arch 2021-03-22
Linked BF Score:
161

As an incidental change in ~~SERVER-53399~~, the author added implicit conversions in both directions between StringData and std::string_view. Use of std::string_view is not generally allowed in the mongodb codebase, and this change has important API consequences that should be further considered. If nothing else, tests of the functionality would be needed if we keep it.

is caused by

SERVER-51266 Add support for BSONType::RegEx in SBE

Closed

SERVER-53399 Implement registration and basic parsing/serializing mechanism for window functions

Closed

is duplicated by

SERVER-48470 Use StringData instead of std::string_view in SBE code

Closed

is related to

SERVER-43583 StringData should get most or all string_view member functions

Backlog

SERVER-32422 convert StringData to std::string_view

Backlog

SERVER-54352 StringData should offer std::string += StringData overload.

Closed

related to

SERVER-55381 StringData find and rfind incorrect results

Closed

(1 is related to, 1 related to)

Assignee:: Billy Donahue

Reporter:: Billy Donahue

Participants:: Billy Donahue, Githook User

Votes:: 0 Vote for this issue

Watchers:: 17 Start watching this issue

Created:: Mar 13 2021 07:17:53 AM UTC

Updated:: Oct 29 2023 09:56:20 PM UTC

Resolved:: Mar 21 2021 09:48:46 AM UTC

Details

Description

Attachments

Issue Links

Activity

People

Dates