Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55204

Opt in to -Wimplicit-fallthrough in src/mongo

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.1.0-rc0
    • Affects Version/s: None
    • Component/s: Build, Internal Code
    • Labels:
      None
    • Fully Compatible
    • Dev Platform 2022-04-18
    • 65

      This is a very easy bug to accidentally type, and can be hard to notice in code review. There are only a handful of current violations. I haven't checked if any are bugs, but even if they aren't, it seems like it would be easier for the reader to have an explicit [[fallthrough]] annotation.

            Assignee:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: