Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55204

Opt in to -Wimplicit-fallthrough in src/mongo

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 6.1.0-rc0
    • Build, Internal Code
    • None
    • Fully Compatible
    • Dev Platform 2022-04-18
    • 65

    Description

      This is a very easy bug to accidentally type, and can be hard to notice in code review. There are only a handful of current violations. I haven't checked if any are bugs, but even if they aren't, it seems like it would be easier for the reader to have an explicit [[fallthrough]] annotation.

      Attachments

        Issue Links

          Activity

            People

              andrew.morrow@mongodb.com Andrew Morrow
              mathias@mongodb.com Mathias Stearn
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: