Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55259

build.ninja should always be left in a clean state by scons even if interrupted

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.0
    • Component/s: Build
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Backport Requested:
      v5.1, v5.0, v4.4
    • Sprint:
      Dev Platform 2021-09-06, Dev Platform 2021-09-20, Dev Platform 2021-10-04, Dev Platform 2021-10-18

      Description

      Currently build.ninja is deleted by scons prior to rebuilding it. This means that if you interrupt it while it is being rebuilt, you can't just rerun ninja again, and instead must reinvoke scons, remembering any and all flags you previously passed it. Using SCons' Precious() helps here. In addition, you should write to a temporary file and rename on top of build.ninja when done writing to ensure that it is atomically replaced.

        Attachments

          Activity

            People

            Assignee:
            ryan.egesdahl Ryan Egesdahl
            Reporter:
            redbeard0531 Mathias Stearn
            Participants:
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: