Catalog cache refreshes are not being retried on SnapshotError when going through shard_local

XMLWordPrintableJSON

    • Fully Compatible
    • ALL
    • Sharding 2021-04-05
    • 53
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      CatalogCache will retry if the refresh fails with SnapshotError. However, when the refresh uses shard_local::runAggregation (i.e. when the config server refreshes its own cache), the SnapshotError is not propagated back to the catalog_cache. Instead, the catalog cache sees a CommandFailed error and does not retry. This happens because the SnapshotError gets masked here and converted to CommandFailed.

      To address this bug we could change this to instead be:

      return getStatusFromCommandResult(ret);
      

              Assignee:
              Jordi Serra Torrens
              Reporter:
              Jordi Serra Torrens
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: