Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55616

Instances of ShardingDDLCoordinator are not throwing on NotPrimaryError nor ShutdownError

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0
    • Component/s: Sharding
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Sprint:
      Sharding 2021-04-05
    • Linked BF Score:
      165

      Description

      The current implementation of the onCompletion callback on the instances of the ShardingDDLCoordinator are simply returning if there was a NotPrimaryError or ShutdownError category, if there is a write and the DDL operation fails because of a stepdown, then that error would not propagate to the router nor the operation retried, giving an ok:0 result to the user when actually the operation haven't finished. We should throw on those categories but leaving the current approach of not removing the coordinator document on those scenarios.

        Attachments

          Issue Links

          is caused by

          Task - A task that needs to be done. SERVER-54587 Make create collection resilient to stepdowns

          • Major - P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. SERVER-54605 Make rename collection coordinator resilient to stepdowns

          • Major - P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. SERVER-54944 Make drop collection resilient to stepdowns

          • Major - P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. SERVER-54945 Make drop database resilient to stepdowns on sharded cluster

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              marcos.grillo Marcos José Grillo Ramirez
              Reporter:
              marcos.grillo Marcos José Grillo Ramirez
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: