Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55808

icecream and ninja affecting configure commands

XMLWordPrintableJSON

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Fully Compatible
    • ALL
    • Hide

      Generate ninja build with VERBOSE=1, and notice the config logs for fallocate are empty, it should have the commands used for the configure check printed to the logs.

       

      Also using icecream, after you have fixed ninja breaking the logs, you will notice the same fallocate configure step has icerun in it.

      Show
      Generate ninja build with VERBOSE=1, and notice the config logs for fallocate are empty, it should have the commands used for the configure check printed to the logs.   Also using icecream, after you have fixed ninja breaking the logs, you will notice the same fallocate configure step has icerun in it.
    • Dev Platform 2021-04-19

      The configure steps should not be affected by icecream or ninja because these tools are used during the actual build and not in build preparation.

      Ninja was hiding the conf logs, by making a noop function for 
      PRINT_CMD_LINE_FUNC.
       
      Icecream was using icerun for configure commands which use some of the builders besides compilation builders, which in those cases icecream should handle and run locally, however in some cases icecream will hang, causing confusion when this happens during a configure check. In order to reduce the number of moving parts, icecream should take no part in general configure steps.

            Assignee:
            daniel.moody@mongodb.com Daniel Moody
            Reporter:
            daniel.moody@mongodb.com Daniel Moody
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: