Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55887

Remove util/unowned_ptr.h

    XMLWordPrintableJSON

Details

    • Icon: Question Question
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 5.0.0-rc0
    • None
    • Internal Code
    • None
    • Fully Compatible
    • Service Arch 2021-05-03

    Description

      unowned_ptr is only used in two functions.
      These functions can just as easily use raw pointers.

      Then we can get rid of a file in util and its test.

      src/mongo/db/exec/working_set_common.cpp-69-bool WorkingSetCommon::fetch(OperationContext* opCtx,
      src/mongo/db/exec/working_set_common.cpp-70-                             WorkingSet* workingSet,
      src/mongo/db/exec/working_set_common.cpp-71-                             WorkingSetID id,
      src/mongo/db/exec/working_set_common.cpp:72:                             unowned_ptr<SeekableRecordCursor> cursor,
      src/mongo/db/exec/working_set_common.cpp-73-                             const NamespaceString& ns) {
      src/mongo/db/exec/working_set_common.cpp-74-    WorkingSetMember* member = workingSet->get(id);
      src/mongo/db/exec/working_set_common.cpp-75-
      --
      src/mongo/db/exec/working_set_common.h-52-    static bool fetch(OperationContext* opCtx,
      src/mongo/db/exec/working_set_common.h-53-                      WorkingSet* workingSet,
      src/mongo/db/exec/working_set_common.h-54-                      WorkingSetID id,
      src/mongo/db/exec/working_set_common.h:55:                      unowned_ptr<SeekableRecordCursor> cursor,
      src/mongo/db/exec/working_set_common.h-56-                      const NamespaceString& ns);
      src/mongo/db/exec/working_set_common.h-57-};
      src/mongo/db/exec/working_set_common.h-58-
      --
      src/mongo/db/sorter/sorter.cpp-518-    class STLComparator {  // uses greater rather than less-than to maintain a MinHeap
      src/mongo/db/sorter/sorter.cpp-519-    public:
      src/mongo/db/sorter/sorter.cpp-520-        explicit STLComparator(const Comparator& comp) : _comp(comp) {}
      src/mongo/db/sorter/sorter.cpp:521:        bool operator()(unowned_ptr<const Stream> lhs, unowned_ptr<const Stream> rhs) const {
      src/mongo/db/sorter/sorter.cpp-522-            // first compare data
      src/mongo/db/sorter/sorter.cpp-523-            dassertCompIsSane(_comp, lhs->current(), rhs->current());
      src/mongo/db/sorter/sorter.cpp-524-            int ret = _comp(lhs->current(), rhs->current());

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: