Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-56216

Commit queue should verify no open TODOs in code

    XMLWordPrintable

    Details

    • Backwards Compatibility:
      Fully Compatible
    • Backport Requested:
      v4.9, v4.4
    • Sprint:
      DAG 2021-05-03, DAG 2021-05-17
    • Story Points:
      2

      Description

      There is a Jira TODO bot that scrapes the codebase for TODOs that reference closed tickets. Frequently, I don't find out about these TODOs until I have already closed the ticket. It then takes time to triage the ticket, etc.

      It would be extremely useful to have a commit-queue task (or even a sometimes-enabled patch build task) as a line of defense. It should fail when there is an outstanding TODO in the code that references your ticket number. I don't know what the current bot does. We should check with the TPMs for the current script.

      I assume it just uses a regex like this: TODO.*<ticket>

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              david.bradford David Bradford
              Reporter:
              louis.williams Louis Williams
              Participants:
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: