Index builds must set the PrepareConflictBehavior::kIgnoreConflictsAllowWrites flag on the RecoveryUnit on resume in the drain phase

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 5.0.0-rc0
    • Affects Version/s: None
    • Component/s: Storage
    • None
    • Fully Compatible
    • ALL
    • Execution Team 2021-05-17
    • 150
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      A resumed index build goes through this if-else-if statement in the index build code wherein mutual setup code sets the PrepareConflictBehavior::kIgnoreConflictsAllowWrites flag on the RecoveryUnit. Setting that flag avoids a possible invariant check that the index build thread is killable (to avoid prepare conflict deadlocks).

      The drain phase does not execute the if-else-if code, it is the undefined else situation. For that else situation (drain phase) we still need to set the PrepareConflictBehavior::kIgnoreConflictsAllowWrites flag on the RecoveryUnit. I recommend pulling the mutual code up, so it's more clear that the flag is set and more difficult to accidentally forget.

              Assignee:
              Gregory Wlodarek
              Reporter:
              Dianna Hohensee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: