Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-56750

Check for todo comments as part of running upload.py

    XMLWordPrintableJSON

Details

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 5.0.0-rc0
    • None
    • Testing Infrastructure
    • None
    • Fully Compatible
    • DAG 2021-05-17
    • 2

    Description

      We recently added todo comment checking as part of the server commit queue. This is
      useful, but fails a commit-queue entry if something is wrong. It would be nice to have
      some early checks as well to warn engineers that there is an issue before submitting to
      the commit-queue.

      One possible solution is to add the check to the upload.py script. This script already
      has options to do things like linting, so the todo check should fit in with those.


      As a database contributor,
      I want to about unresolved todo in my code before commit-queue time,
      So that I can fix them before I submit my code to the commit-queue.


      AC:

      • Check for Todo comments happe as part of running upload.py

      Attachments

        Activity

          People

            david.bradford@mongodb.com David Bradford (Inactive)
            david.bradford@mongodb.com David Bradford (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: