Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-56898

investigate library exclusion interface for PCH tool

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Backlog
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Operating System:
      ALL

      Description

      While working on SERVER-55839 it was found that certain libraries did not play nice with the following header set inside the mongo/db directory:

      #include <mongo/db/namespace_string.h>
      #include <mongo/db/commands.h>
      #include <mongo/db/auth/authorization_session.h>
      #include <mongo/db/db_raii.h>
      

      The libraries which had issues were src/mongo/db/query/datetime/date_time_support and src/mongo/db/repl/split_horizon.

      For the investigation being performed in the mentioned ticket, these library were all together excluded from PCH to not spend to much time on the issue and still demonstrate measurable gains.

       

      Instead of excluding the library all together at the library declaration, it would be more preferable to have it exclude the particular library for the particular PCH at the PCH declaration for neatness and making those libraries be selective for other pch's.

       

      This would also allow issues found from certain libraries to not prevent potential performance gains, while other teams investigate and potentially fix such issues.

        Attachments

          Activity

            People

            Assignee:
            backlog-server-devplatform Backlog - Server Development Platform Team (SDP)
            Reporter:
            daniel.moody Daniel Moody
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: