Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-5727

log rotate() is missing a lot of error checking

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Gone away
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Logging
    • Labels:
    • Operating System:
      ALL

      Description

      The following functions in rotate() need to have their return statuses checked for errors so we don't have confusing behavior when things fail silently:
      rename()
      CreateFileA()
      freopen()
      dup2()

      If these functions fail, we should write to stderr and translate errno.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-8160 The rotateLogs() function doesn't print errno when the rename() fails

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-20480 Logrotate fails with no error message if the log dir ownership/permissions are incorrect

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              backlog-server-platform Backlog - Platform Team
              Reporter:
              milkie Eric Milkie
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: