Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-57384

Remove serverStatus counters and logging for deleted opcodes

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor - P4
    • Resolution: Fixed
    • None
    • 6.1.0-rc0
    • None
    • None
    • Fully Compatible
    • QE 2022-07-11, QE 2022-07-25, QE 2022-08-08

    Description

      We are planning to remove support for OP_INSERT, OP_UPDATE, OP_DELETE, OP_QUERY, OP_GET_MORE, OP_KILL_CURSORS, and getLastError in an upcoming version (likely 5.1). However, we are going to leave logic from SERVER-56501 to count attempted uses of the deleted opcodes. This will allow us to determine whether, and how often, applications are attempting to use the no-longer-supported op codes against a particular server. Similarly, the warning logging first introduced in SERVER-55788 will be initially left in place.

      Eventually, once we are sure that users have taken all necessary action to avoid use of the legacy opcodes, we should delete the remaining traces of the legacy opcodes in the server code. Rather than producing a clean error message saying something like "OP_QUERY is no longer supported, please upgrade your driver", logging a warning to the same effect, and bumping a serverStatus() counter, after this change the server will instead produce an error with some obscure error message related to validation of the wire protocol message's structure (something like "unknown opcode 2004").

      The version in which we should make this change is an open question. My initial proposal would be to schedule it for some version greater than 6.0, for example 6.1 or 6.2. That way, the initial deprecation will have happened in 5.0, there will still be useful error messages in 6.0, and post-6.0 all traces of the legacy opcodes will finally be fully removed.

      Attachments

        Issue Links

          Activity

            People

              irina.yatsenko@mongodb.com Irina Yatsenko
              david.storch@mongodb.com David Storch
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: