Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-58024

Audit NetworkInterfaceTL for calls to exception-throwing fns in getAsync continuations

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: None
    • Operating System:
      ALL
    • Story Points:
      4

      Description

      In SERVER-49435, we observed an instance of an exception-throwing function being called from a getAsync continuation. getAsync continuations are effectively noexcept (there is no "correct" context in which to handle an async-exception, so the process is terminated).

      Because that ticket was causing a hot BF, we elected to simply fix the issue minimally by converting the relevant exception to a status within the function called in getAsync. But we already have found at least one other instance of this problem that has not yet been caught in tests: the call to continueExhaustRequest in a getAsync here may throw via its call to setTimer.

      As much of the code in this class is run in getAsync continuations, and we have already encountered this twice, we should
      1) Fix the issue described in the last paragraph
      2) Audit all the getAsync continuations in this file to make sure they don't call into functions that may throw.

        Attachments

          Activity

            People

            Assignee:
            backlog-server-servicearch Backlog - Service Architecture
            Reporter:
            george.wangensteen George Wangensteen
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: