Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-58123

Avoid logging multiple times when restarting cancelled heartbeats

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.2.0-rc0
    • None
    • None
    • Replication
    • Fully Compatible
    • Repl 2023-09-04, Repl 2023-09-18
    • 126

    Description

      In _restartScheduledHeartbeats_inLock(), we will only restart heartbeats that have been scheduled, not sent. However, we do not check if those scheduled heartbeats have been cancelled or not, and we will immediately log that we are restarting heartbeats to that target. As a result, it is possible for us to log that we are restarting heartbeats multiple times to a single target, making the logs confusing and difficult to debug.

      We should move the logs to when we actually send a new heartbeat request to the target instead. This should only log once.

      Attachments

        Activity

          People

            evelyn.wu@mongodb.com Evelyn Wu
            xuerui.fa@mongodb.com Xuerui Fa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: